Merged
Conversation
# Conflicts: # src/test/java/dev/zarr/zarrjava/ZarrV2Test.java
…ault to a new MemoryStore
brokkoli71
commented
Nov 28, 2025
src/main/java/dev/zarr/zarrjava/store/ConcurrentMemoryStore.java
Outdated
Show resolved
Hide resolved
normanrz
approved these changes
Dec 5, 2025
|
|
||
| List<String> resolveKeys(String[] keys) { | ||
| ArrayList<String> resolvedKeys = new ArrayList<>(); | ||
| for(String key:keys){ |
Member
There was a problem hiding this comment.
Do we have a code formatter set up?
Member
Author
There was a problem hiding this comment.
No, the code is not uniformly formatted. Sometimes it's two spaces and sometimes it's tabs.
Member
Author
There was a problem hiding this comment.
I could format the entire code in a separate PR, so that changes are easier to understand?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
MemoryStore(fixes Add MemoryStore #35)Minor changes:
v2.Group.setAttributesTODO:
MemoryStore